This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Use username library for name detection #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chromecube <chromecube@t-online.de>
Owner
|
Sindre Sorhus strikes again! I'm just going to quick-edit the PR to keep the async error handling structure we had, since Thanks for this! |
Contributor
Author
|
No Problem, glad to help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using eDEX-UI on Windows, I noticed that my name did not appear at startup. I searched for solutions and the best suitable in my mind is the username library, because it is lightweight and very simple to use.
It has a lot of fallback methods to get a username and runs just fine on Linux, Windows and macOS. It would be super cool if you could take this method into consideration!
Kind Regards,
Niklas