This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Don't refresh filesystem if path hasn't changed #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitSquared
reviewed
Jul 11, 2020
Owner
GitSquared
left a comment
GitSquared
left a comment
There was a problem hiding this comment.
Well done.
I'm wondering if down the road, a better solution would be to separate the model/view, so that a cache of the filesystem can be stored for each open tab (or a maximum of n tabs), and then a single filesystem widget can then just switch between the current model that it's displaying.
Down the road, the entire app will probably get rewritten. Maybe if TRON 3 releases.
GitSquared
approved these changes
Jul 11, 2020
DongyunLee
pushed a commit
to 88hack/edex-ui
that referenced
this pull request
Aug 18, 2020
eugene2candy
pushed a commit
to eugene2candy/edex-ui
that referenced
this pull request
Apr 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching between tabs with the same path will refresh the filesystem widget, even if it's not required.
I'm wondering if down the road, a better solution would be to separate the model/view, so that a cache of the filesystem can be stored for each open tab (or a maximum of n tabs), and then a single filesystem widget can then just switch between the current model that it's displaying.