-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat: audio, video and pdf reader #953
feat: audio, video and pdf reader #953
Conversation
|
Love the PDF reader! But the audio player seems kind of out-of-place. Could we perhaps style it to fit in a bit more? |
|
No problem! I can change it |
|
I've been doing some testing, and ogg files trigger the video player, not the audio player. Not sure if this is an issue at all. |
|
Not ideal, but no blocking bug either, I'd say. |
|
Agreed, especialy since that happens because lstat reports the type as video. |
|
Woah, those look great! Any chance you two could coordinate on merging those changes? Otherwise, we'd go the two-PRs route. |
|
That should be possible. @ghost-in-the-machine-86 how would it be best to get these changes to you? Or were you already working on something similar? |
|
I did this media player, but i prefer your style @KjartanOli! Maybe i can add volume/progress bars to your player |
|
Sounds great. I had no idea how to implement those. How should I send my code to you? |
|
Idk how can you change my code from here (my first pull request), so i invited you to my repository |
|
I just pushed my code to you develop branch. |
|
thanks! |
|
You'll have to merge |
|
Fixed ogg files to trigger audio player and applied @KjartanOli style to media player with some changes |
|
Is this ready for review? |
|
Yes |
GitSquared
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Kjartan Óli Ágústsson <kjartanoli@protonmail.com>




Implementing audio tag to play music and pdf reader with pdfjs https://github.com/mozilla/pdf.js/ and custom buttons (zoom in/out and previous/next page)