removed command line arguments escape logic

[denisbredikhin]

This pull request fixes an issue introduced in PR #1988, where exec was replaced with execFile but the existing argument-escaping logic was left in place. Since execFile passes arguments directly to the process without invoking a shell, the previous escaping logic caused arguments to include literal quotes and backslashes. On Windows, this resulted in invalid path resolutions and errors like:

The filename, directory name, or volume label syntax is incorrect.

This update removes all manual argument escaping so that execFile receives the correct raw argument values.

My apologies for the regression introduced in the earlier PR.

[Copilot]

Pull request overview

Removes manual command-line argument quoting/escaping from ArgumentsBuilder now that tools are executed via execFile, which passes arguments directly to the process (avoiding the regression where literal quotes/backslashes broke Windows paths).

Changes:

• Stop escaping/quoting values for addArgument, addKeyValue, addKeyValueEquals, and addCommaList.
• Remove the OS-specific escape/needsEscaping helpers.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[arturcic]

@denisbredikhin please check this one as well #2006

[denisbredikhin]

@denisbredikhin please check this one as well #2006

I think changes in this PR should fix that issue too.
Maybe it would be good to change exception message from

throw new WarningException($"Could not parse /overrideconfig option: {keyValueOption}. Unsupported 'key'.");

to something like

throw new WarningException($"Could not parse /overrideconfig option: {keyValueOption}. Unsupported key {optionKey}.");

If you agree can you open a new issue at GitTools/GitVersion?

[arturcic]

fine by me open an issue and a PR if you don't mind

[arturcic]

@denisbredikhin hey when you're done with the changes please squash them as a commit

[denisbredikhin]

@denisbredikhin hey when you're done with the changes please squash them as a commit

won't I be able to "Squash and merge" when you approve?

[arturcic]

@denisbredikhin hey when you're done with the changes please squash them as a commit

won't I be able to "Squash and merge" when you approve?

we usually do not enable that option, so better you do that, we then merge

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mergify]

Thank you @denisbredikhin for your contribution!

[denisbredikhin]

@arturcic I see so .vsix file in the assets of the release.
And marketplace is not updated...

[arturcic]

We have a 2step release process, first it goes to a gittools.gittools-test extension which runs on another repository to validate it did not broke, and then goes the official, wait couple of minutes