Upgrade to Tauri v2#71
Conversation
|
Oh this is a bit unexpected :D The app frontend is being rewritten from scratch actually. Every single piece of code is changing but I loved the Tauri v2 update, because I was a bit afraid if it might brake the auto updater. I'm also thinking to remove https://gitification.app website dependency and use raw github. I'd love to merge and review this but the frontend in my side is whole different code, but for tauri v2 update I'd love to merge it. thanks for the contribution |
|
Can you just create a PR for only tauri v2 upgrade? here's a peek of current phase: #72 Over the three years since I created this library my whole coding style is changed. |
|
Oh that's exciting! I didn't realize you already had so much in flight for the rewrite. Sure, I'm happy to separate-out the Tauri upgrade. Or if you'd prefer, I could take your rewrite branch and use that as the base for the Tauri upgrade and post that PR back for you. |
|
Or I guess maybe it makes sense to land the Tauri upgrade alone and then you can land the rewrite on top of Tauri V2 when you're ready. Either works for me. |
|
I believe my PR will have so much work on it :D I'm rewriting everything, not just a single update. I don't like the organization of the code. Theme is being rewritten, I even considered moving from Vue to react or solidjs because I don't like sfcs :) |
yep, only tauri updates which I can merge alongside rewritten UI is good. |
4745811 to
9647f79
Compare
|
@kadiryazici I pruned this down to just the necessary changes for the Tauri v2 upgrade and re-verified on MacOS and Windows (Linux caveat still applies). |
|
Blocked by #72 @bobziuchkovski thank you for your contribution ::::)))) after overall rewrite of frontend, I'll ship an update and then tauri v2 will be merged and tested. |
|
No problem! |
|
@bobziuchkovski 2.0.0 is released. But I couldn't get my v1 to update to v2. Might need to uninstall and update again. Still I'm trying to fix updater to work for v1 apps |
|
@bobziuchkovski v2 bugs are fixed, 2.0.7 is updateable from v1. We might need to close this PR and create one from scratch, there are so many conflicts |
Explanation (Required):This is meant to help unblock some of the planned functionality you mentioned here. Specifically I'd still love to see support for multiple Github accounts. 😄
This PR migrates to Tauri v2.
I've verified behavior of the MacOS and Windows builds. I also tested on Linux but the system tray handling is broken. I confirmed it's broken on v1.3.1 as well, so not a regression. I can provide more details and a potential Linux fix if you'd like.
Updater Handling: This branch is deliberately set up so v1.3.1 clients in the wild keep working and can pull updates to this Tauri v2 build. You just need to update the signing ENV vars (TAURI_SIGNING_PRIVATE_KEY / TAURI_SIGNING_PRIVATE_KEY_PASSWORD). These were renamed in the tauri-action Github Action. The updater endpoint should continue serving a JSON manifest matching the current shape that the v1 clients consume. As long as you use the same signing key, everything should continue to work, though in transparency I didn't set up a manifest/updater endpoint on my end to verify this.