Skip to content

Fix clippy#1918

Merged
Eliah Kagan (EliahKagan) merged 1 commit intoGitoxideLabs:mainfrom
EliahKagan:fix-clippy
Apr 4, 2025
Merged

Fix clippy#1918
Eliah Kagan (EliahKagan) merged 1 commit intoGitoxideLabs:mainfrom
EliahKagan:fix-clippy

Conversation

@EliahKagan
Copy link
Copy Markdown
Member

@EliahKagan Eliah Kagan (EliahKagan) commented Apr 4, 2025

clippy has recently begun to fail with:

error: unnecessary semicolon
  --> gix-transport/src/client/blocking_io/http/traits.rs:30:18
   |
30 |                 };
   |                  ^ help: remove
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon
   = note: `-D clippy::unnecessary-semicolon` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::unnecessary_semicolon)]`

While it looks like this might first have been observed in #1917, it is unrelated to any change there. It happens when the current tip of main (4660f7a) is rerun, as observed in:
https://github.com/EliahKagan/gitoxide/actions/runs/14254079128/job/39958292846


This is initially empty as I'm double checking that it does happen. I'll amend with a fix shortly.

Edit: Yes, it reproduces here. I've amended to add the fix.

@Byron
Copy link
Copy Markdown
Member

Thank you. Please feel free to merge this when it's ready.

@EliahKagan
Copy link
Copy Markdown
Member Author

Eliah Kagan (EliahKagan) commented Apr 4, 2025

There's at least one other failure, which clippy didn't get to after the first one. I'll fix it too, and any others.

Edit: Running just clippy-fix and etc/copy-packetline.sh fixed it the rest of the way.

This removes some extra unnecessary semicolons that `clippy` has
recently begun to catch, causing CI to fail with errors such as:

    error: unnecessary semicolon
      --> gix-transport/src/client/blocking_io/http/traits.rs:30:18
       |
    30 |                 };
       |                  ^ help: remove
       |
       = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_semicolon
       = note: `-D clippy::unnecessary-semicolon` implied by `-D warnings`
       = help: to override `-D warnings` add `#[allow(clippy::unnecessary_semicolon)]`

While it looks like this might first have been observed in GitoxideLabs#1917,
it is unrelated to any change there. It happens when the current
tip of main (4660f7a) is rerun, as observed in:
https://github.com/EliahKagan/gitoxide/actions/runs/14254079128/job/39958292846

This runs `just clippy-fix` and `etc/copy-packetline.sh` to fix it.
@EliahKagan Eliah Kagan (EliahKagan) merged commit 4d3946f into GitoxideLabs:main Apr 4, 2025
21 checks passed
@EliahKagan Eliah Kagan (EliahKagan) deleted the fix-clippy branch April 4, 2025 02:05
@EliahKagan Eliah Kagan (EliahKagan) mentioned this pull request Apr 4, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants