Skip to content

Use imara-diff-v2 by default#2513

Merged
Sebastian Thiel (Byron) merged 7 commits intomainfrom
v2-diff
Apr 16, 2026
Merged

Use imara-diff-v2 by default#2513
Sebastian Thiel (Byron) merged 7 commits intomainfrom
v2-diff

Conversation

@Byron
Copy link
Copy Markdown
Member

@Byron Sebastian Thiel (Byron) commented Apr 13, 2026

Tasks

  • refackview
  • remove gix-imara-diff-01
  • reduce gix-imara-diff to its core and make sure the license is properly respected

Codex (codex) and others added 2 commits April 16, 2026 14:13
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
The slider post-processing imrpoves the diff quality for about 8% slower diffs.
Line-counts, however, will be 50% faster to compute.

Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Copy link
Copy Markdown
Contributor

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 80211887ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

Comment thread gitoxide-core/src/repository/diff.rs Outdated
Comment thread gix-diff/src/blob/platform.rs Outdated
Codex (codex) and others added 5 commits April 16, 2026 22:19
Make CI pass again

Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
Leave the unified diff printer, as it's now used in tests.
Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
@Byron Sebastian Thiel (Byron) merged commit 2a5db88 into main Apr 16, 2026
32 checks passed
@Byron Sebastian Thiel (Byron) deleted the v2-diff branch April 16, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants