Docstring weight handling fixes, Allow 3 algorithms to use weights, Fix crash in lswl_plus, expose leiden resolution parameter, expose more weights parameters#251
Merged
GiulioRossetti merged 14 commits intoGiulioRossetti:masterfrom Jul 14, 2025
Conversation
…esolution_parameter
…ts weights but the cdlib wrapper was not exposing it.
…ights. The algorithm can be extended to handle edge weights but cdlib's implementation does not.
…pose WALKSCAN's weight parameter
Agade09
changed the title
Agade09
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many docstrings were stating that an algorithm didn't support edge weights when it did (rber_pots, CPM, greedy_modularity, WALKSCAN, ASLPAw).
DER's docstring was incorrectly stating that it did support edge weights.
igraph's walktrap can use edge weights but the cdlib wrapper simply wasn't exposing it.
The leiden wrapper was not providing access to the resolution_parameter.
Many weighted-graph-handling algorithms in this library do not expose the weight parameter, while some do. In this PR I try to improve consistency in that regard by exposing the weight parameter for Infomap and AGDL.
lswl_plus was crashing on my graphs and in this PR I provide a fix.
LFM and UMSTMO required relatively minor modifications to be able to use edge weights.