LFM fix, sbm_dl/sbm_dl_nested fix#252
Merged
GiulioRossetti merged 7 commits intoGiulioRossetti:masterfrom Sep 30, 2025
Merged
Conversation
…his was less likely to happen in the unweighted form, but after the weighted LFM implementation this issue was observed and fixed.
…zed np.int32 but not np.int64
…d, default value of 0 was always used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a typo in the documentation of sbm_dl_nested where the code example was calling sbm_dl instead of sbm_dl_nested.
Fixed a utility function called by sbm_dl and sbm_dl_nested which would treat np_int64 as a list because the if statement was checking for np.int32 instead of np.integer.
The LFM implementation could get stuck discovering the same communities in a loop. A fix is implemented by using a set and preventing such cycles. My understanding is this issue was present in the unweighted code but more likely to happen now that the weighted version was implemented in this commit.
Give a meaning to level==-1 for girvan-newman. With level==-1, the communities with the highest modularity will be returned. My understanding is that this is the standard way of using girvan-newman. We could even make level==-1 the default value for this parameter.
Fixed a serious typo in LPAM implementation causing crash if distance=='cm'. Also fixed typo causing seed parameter to be ignored.