Execute deploy hooks #836
Open
Execute deploy hooks #836
+13
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AronNovak
reviewed
May 5, 2025
.ddev/config.local.yaml.example
Outdated
| # Run DB updates. | ||
| - exec: drush updb | ||
| # Run deploy hooks. | ||
| - exec: drush deploy:hook --no-interaction |
Member
There was a problem hiding this comment.
We should preserve drush updb, shouldn't we?
Also this should be the last step, after config import, see the Robo logic.
mariano-dagostino
approved these changes
May 6, 2025
Collaborator
mariano-dagostino
left a comment
mariano-dagostino
left a comment
There was a problem hiding this comment.
No need to run drush updb, deploy:hook includes it as first step.
Member
|
Then should we adapt DeploymentTrait.deployPantheonSync too to do the same logic? |
AronNovak
reviewed
Aug 17, 2025
| # hosting environment won't provide unlimited | ||
| # memory either. | ||
| # @see https://github.com/drud/ddev/issues/1825#issuecomment-529964728 | ||
| - exec: perl -pi -e 's/memory_limit.*$/memory_limit = -1/' /etc/php/${DDEV_PHP_VERSION}/cli/conf.d/*.ini |
Member
There was a problem hiding this comment.
This is a bit dangerous. We create plenty of Drush commands what will run in a limited environment. So this means a memory-hungry Drush operation will work smoothly locally and fail on Pantheon. I doubt that we want it.
See #838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted on a client's project