-
Notifications
You must be signed in to change notification settings - Fork 55
Paragraphs Simple Edit - CRUD on separate pages #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
amitaibu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, bump to total 10h.
...om/paragraphs_simple_edit/src/Plugin/Field/FieldWidget/ParagraphsSimpleEditDefaultWidget.php
Show resolved
Hide resolved
|
As we are on 11h, bump to total 15h. Ideally that could also include tests |
|
Added controller with add form. Checking the problems. TB: 12/15h |
|
@amitaibu I found a module Paragraphs Modal Add. This module provides a route for adding a paragraph. We can use the route provided by this module in our field widget for add links. I tested on my local & the add form works fine. TB: 12.5/15 |
|
I thought about using the module for add form, but it only opens up paragraph type selection in modal & then show the form in field widget which we don't want. See video below: para-edit.mp4So our field widget is still needed with route from Paragraphs Modal Add. If we don't want the dependency of the module, we can just use the code in our module. My recommendation would be using the route from module by keeping the dependency instead of writing all the code again. The module already has add form implemented. |
|
Thanks, for now we can add a dependency on |
|
Changes for settings & phpstan/phpcs fixes. TB: 13.5/15h |
|
Thanks, can you please share a video of how it looks so far |
|
Here it is: paragraph-working.mp4For new nodes, it is showing default paragraph widget since add/edit/delete route needs parent entity id & we don't have it at the time. We need to think on this. Added tests but trying to set up phpunit that includes files from paragraphs as well since our test is depend on it. TB: 14.5/15h |
Bump to total 17h |
|
|
np, I thought, by the name Let's first get it to work without a modal, and then we can decide if we want to switch. |
|
It is working in standalone page. We are just using route from Paragraphs Modal Add. |
|
We now have working widget for paragraphps add/edit/delete links to open on standalone pages. The UX is as per video in #938 (comment). Limitations:
TB: 16.5/17h |
|
Let's add a test to check the widget appears correctly in different scenarios. Bump to 19h |
|
Added more tests. TB: 17.5/19h |
|
@codex resolve conflicts and review |
|
Codex couldn't complete this request. Try again later. |
|
@codex resolve conflicts |
|
Codex couldn't complete this request. Try again later. |
|
@tanmayk can you please resolve the conflicts |
|
Resolved conflicts. TB: 17.75/19h |



#783
The widget is ready with required changes. Working on
addroute still.TB: 6h