Sped up the refresh of package updates #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popara96
approved these changes
May 14, 2025
JoC0de
requested changes
May 17, 2025
Collaborator
Author
|
I had to add try catch in GetUpdates Task.Run because Unity would sometimes get stuck if OperationInterruptedException was thrown within. |
JoC0de
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added additional Artifactory source that has a lot of packages with a lot of versions and opening Nuget window started taking 20s. I moved fetching updates when window is opened to a background thread so that window is opened much faster. I also sped up the fetching of package updates by using Task.WhenAll to fetch them all in parallel instead of one by one. In case window is closed while fetching is in progress CancellationToken is used to cancel it all.