Support access control allow headers #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…determine if a audio stream supports seek
Jackstone92
reviewed
Dec 15, 2022
| NSString *accessControlAllowHeaders = ([httpHeaders objectForKey:@"Access-Control-Allow-Headers"] ?: [httpHeaders objectForKey:@"access-control-allow-headers"]); | ||
| if (([httpHeaders objectForKey:@"Accept-Ranges"] ?: [httpHeaders objectForKey:@"accept-ranges"]) != nil || | ||
| (accessControlAllowHeaders != nil && | ||
| ([accessControlAllowHeaders rangeOfString:@"Range"].location != NSNotFound || [accessControlAllowHeaders rangeOfString:@"range"].location != NSNotFound))) |
There was a problem hiding this comment.
Could this potentially be condensed by only needing to check for a single rangeOfString against a lowercased accessControlAllowHeaders?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some audio files don't contain the usual
Accept-Range: trueheader, instead it looks more like the following:"Access-Control-Allow-Headers" = "Authorization,Accept,Origin,DNT,X-CustomHeader,Keep-Alive,User-Agent,X-Requested-With,If-Modified-Since,Cache-Control,Content-Type,Content-Range,Range,X-Mx-ReqToken".This caused an issue when these files could not seek progress, ending up with infinite buffering.