Reverse the order of searching for packer-io, otherwise on Fedora/Red…#53
Reverse the order of searching for packer-io, otherwise on Fedora/Red…#53obilodeau merged 2 commits intoGoSecure:masterfrom malwarenights:master
Conversation
…Hat/Centos
and others the first binary found ('packer') will be always the wrong one from
cracklib package having colliding name
|
I agree with reversing the order of the search for packer-io/packer but not sure for the env var thoug. @obilodeau thoughts? |
|
Should I resubmit without the var? The env var is beneficial, as default on Fedora islibvirt and there is currently no other option than virtualbox in the malbox vagrant boxes so having the explicit preference to virtualbox in the vagrant configuration actually makes sence. If you decide not wanting this one ... it is possible to change the preferece of the default in user's profile or pass on commandline. Mik |
|
I think I'd personally prefer that the env var would be templated and default it to virtualbox. What do you think? I'm pretty sure that's what you meant in your last paragraph. Thx! |
|
Yes I personally preffer to have it in the template, if the template is currently meant to run only in virtualbox. |
|
Thanks for your contribution! Sorry for the wait. |
3 participants
Hello,
the patch 0e0255f is not working properly on the Fedora/Redhat/Centos, because it always picks the colliding packer from the cracklib package.
I would recommend to reverse the order of searching for packer starting with more specific 'packer-io' and then fallback to 'packer'.
Best regards
Michal Ambroz