Skip to content

Commit 5e42394

Browse files
paulirishbrendankenny
authored andcommitted
eslint: no longer ignore all of lighthouse-extension (#613)
* eslint: no longer ignore all of lighthouse-extension * lighthouse eslint can inherit from root.
1 parent 186ce07 commit 5e42394

File tree

4 files changed

+7
-31
lines changed

4 files changed

+7
-31
lines changed

.eslintignore

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
**/node_modules/**
55
**/third_party/**
66

7-
lighthouse-extension/
7+
lighthouse-extension/dist
8+
lighthouse-extension/app/scripts
9+
810

911
**/closure/*/*
1012
coverage/**

.eslintrc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
}],
2727
"quotes": [2, "single"],
2828
"require-jsdoc": 0,
29-
"valid-jsdoc": 0
29+
"valid-jsdoc": 0,
30+
"comma-dangle": 0
3031
}
3132
}

lighthouse-extension/.eslintrc

Lines changed: 2 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,10 @@
11
{
2-
"extends": "google",
2+
"extends": "../.eslintrc",
33
"env": {
44
"browser": true
55
},
66
"globals": {
77
"chrome": true,
8-
"__lighthouse": true,
9-
},
10-
"rules": {
11-
"max-len": [2, 100, {
12-
"ignoreComments": true,
13-
"ignoreUrls": true,
14-
"tabWidth": 2
15-
}],
16-
"no-implicit-coercion": [2, {
17-
"boolean": false,
18-
"number": true,
19-
"string": true
20-
}],
21-
"no-unused-expressions": [2, {
22-
"allowShortCircuit": true,
23-
"allowTernary": false
24-
}],
25-
"no-unused-vars": [2, {
26-
"vars": "all",
27-
"args": "after-used",
28-
"argsIgnorePattern": "(^reject$|^_$)"
29-
}],
30-
"quotes": [2, "single"],
31-
"require-jsdoc": 0,
32-
"valid-jsdoc": 0,
33-
"comma-dangle": 0
8+
"__lighthouse": true
349
}
3510
}

lighthouse-extension/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,6 @@
1212
"brfs": "^1.4.3",
1313
"browserify": "^13.0.0",
1414
"del": "^2.2.0",
15-
"eslint": "^2.4.0",
16-
"eslint-config-google": "^0.4.0",
1715
"gulp": "^3.9.1",
1816
"gulp-chrome-manifest": "0.0.13",
1917
"gulp-debug": "^2.1.2",

0 commit comments

Comments
 (0)