Skip to content

eslint: no longer ignore all of lighthouse-extension#613

Merged
brendankenny merged 3 commits intomasterfrom
eslintext
Aug 27, 2016
Merged

eslint: no longer ignore all of lighthouse-extension#613
brendankenny merged 3 commits intomasterfrom
eslintext

Conversation

@paulirish
Copy link
Member

We had all of the extension ignored in eslintignore.

Now we exclude only the compiled bits.

@brendankenny
Copy link
Contributor

wasn't this on purpose? #482

@paulirish
Copy link
Member Author

wasn't this on purpose? #482

right now npm run lint is running over code in lighthouse-extension/, which is fine if you've never built the extension before (like on travis, where the extension is built last), but fails if you have built it.

It was failing because app/scripts was included (which has the browserified payload).

This PR blacklists both app/scripts and dist.

@brendankenny
Copy link
Contributor

ah, yeah. Still kind of weird because lighthouse-extension/ has its own .eslintrc, lint task, etc.

I think you may need to rebase against master to pass the tests

@brendankenny
Copy link
Contributor

So maybe just sort out the .eslintrc and lighthouse-extension/.eslintrc (with the few differences like node vs browser) and the devDependencies. Not sure how best we want to do this

@paulirish
Copy link
Member Author

all set

@brendankenny
Copy link
Contributor

📝 🔍 ✔️

@brendankenny brendankenny merged commit 5e42394 into master Aug 27, 2016
@brendankenny brendankenny deleted the eslintext branch August 27, 2016 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants