fix: remove extending es6 class from url-shim to support es5 transpilation#1407
Merged
brendankenny merged 1 commit intomasterfrom Jan 5, 2017
Merged
fix: remove extending es6 class from url-shim to support es5 transpilation#1407brendankenny merged 1 commit intomasterfrom
brendankenny merged 1 commit intomasterfrom
Conversation
ebidel
approved these changes
Jan 5, 2017
Contributor
ebidel
left a comment
ebidel
left a comment
There was a problem hiding this comment.
Read my mind :) I tested a similar version locally and it seems to do the trick.
Contributor
|
Verified this fixes the issue. Waiting on the CI |
Member
|
sgtm |
ebidel
changed the title
patrickhulce
changed the title
Contributor
|
:( |
andrewrota
pushed a commit
to andrewrota/lighthouse
that referenced
this pull request
Jan 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.