Update network throttling to simulate more realistic network conditions#2238
Merged
paulirish merged 4 commits intoGoogleChrome:masterfrom May 16, 2017
Merged
Conversation
lighthouse-core/lib/emulation.js
Outdated
|
|
||
| const TARGET_LATENCY = 150; // 150ms | ||
| const TARGET_DOWNLOAD_THROUGHPUT = Math.floor(1.6 * 1024 * 1024 / 8); // 1.6Mbps | ||
| const TARGET_UPLOAD_THROUGHPUT = Math.floor(750 * 1024 / 8 * THROUGHPUT_FACTOR); // 750Kbps |
Collaborator
There was a problem hiding this comment.
why is the throughput factor included in the target here?
lighthouse-core/lib/emulation.js
Outdated
|
|
||
| /** | ||
| * Adjustments needed for DevTools network throttling to simulate | ||
| * more realistic network throttling conditions |
Collaborator
There was a problem hiding this comment.
should we link off to any explanations or references?
Contributor
Author
There was a problem hiding this comment.
Added a link to the crbug (not sure whether to make the analysis doc public yet)
wwwillchen
commented
May 12, 2017
Contributor
Author
wwwillchen
left a comment
wwwillchen
left a comment
There was a problem hiding this comment.
Thanks. Updated.
lighthouse-core/lib/emulation.js
Outdated
|
|
||
| const TARGET_LATENCY = 150; // 150ms | ||
| const TARGET_DOWNLOAD_THROUGHPUT = Math.floor(1.6 * 1024 * 1024 / 8); // 1.6Mbps | ||
| const TARGET_UPLOAD_THROUGHPUT = Math.floor(750 * 1024 / 8 * THROUGHPUT_FACTOR); // 750Kbps |
lighthouse-core/lib/emulation.js
Outdated
|
|
||
| /** | ||
| * Adjustments needed for DevTools network throttling to simulate | ||
| * more realistic network throttling conditions |
Contributor
Author
There was a problem hiding this comment.
Added a link to the crbug (not sure whether to make the analysis doc public yet)
patrickhulce
approved these changes
May 12, 2017
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
looks good! get ready for some really slow runs :)
paulirish
approved these changes
May 16, 2017
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
targetDownloadThroughput etc arent used right now but otherwise. sgtm.
lets land now so we can see how sloooooooow this is!
47 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the work in #2183 which I'll land as a follow-up.