Updated report styles#2297
Conversation
|
Before and after
|
|
I'm using a 12px baseline font for this design. For the standalone report, I'd prefer to use a 14px baseline (should only require tweaking a few CSS variables). Just let me know how we'll differentiate a DevTools- and CLI-generated report and I can make the adjustments. |
@chowse we have Also the |
Adding it to devtools is just a few line change though if we need it |
|
And fwiw here's this PR applied within devtools:
|
|
The same report without the dense DevTools styling:
|
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
looks reaaaaaal nice 👌
|
|
||
| const sparklineBarEl = this._dom.find('.lh-sparkline__bar', tmpl); | ||
| sparklineBarEl.style.width = `${audit.result.rawValue / scale * 100}%`; | ||
| /* |
| passedSummary.textContent = `View ${elements.length} passed items`; | ||
| const passedElem = this._renderAuditGroup({ | ||
| title: `${elements.length} Passed Audits`, | ||
| description: '', |
There was a problem hiding this comment.
can probably just not set this now that we've made it optional
| } | ||
| const nonPassedElem = this._renderAuditGroup({ | ||
| title: `${nonPassedAudits.length} failed audits`, | ||
| description: '', |
| padding-left: var(--expandable-indent); | ||
| } | ||
|
|
||
| .lh-audit-group[open] { |
There was a problem hiding this comment.
does this have any content?
| } | ||
|
|
||
| .lh-category .lh-audit { | ||
| margin-left: calc(var(--default-padding) * 2); |
There was a problem hiding this comment.
are none of these rules needed anymore then?
| --inset-size: calc(var(--circle-size) - var(--circle-border-width)); | ||
| --circle-background: #ccc; | ||
| --circle-border-width: 2px; | ||
| --inset-size: calc(var(--circle-size) - 2* var(--circle-border-width)); |
|
one thing I lose from the previous design is the green encoding of the passing group
in this view i'd love to more clearly see that we do have passing items in the group there.. maybe two overlapping green checks on the right of "8 Passed Audits" ? |
|
I can submit a fix to #2385 once this gets merged |
|
@paulirish do you have a sense of remaining things to resolve? Can we make a list? |
|
Yah. I have a branch pushed with some more work. I'll prep a list of remaining work tonight. |
5 participants
Updated the Lighthouse report's styling to better match the DevTools UI (with options to restyle it using CSS variables).