Merged
Conversation
paulirish
approved these changes
Jun 6, 2017
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
I formatted it with prettier and ended up with very similar output. LGTM
| {"id": "pwa-page-transitions", "weight": 0, "group": "manual-pwa-checks"}, | ||
| {"id": "pwa-each-page-has-url", "weight": 0, "group": "manual-pwa-checks"} | ||
| categories: { | ||
| 'pwa': { |
Member
There was a problem hiding this comment.
you can unquote these category titles
Contributor
Author
There was a problem hiding this comment.
you can unquote these category titles
eslint doesn't like because best-practices is on the same level and needs quotes
patrickhulce
reviewed
Jun 6, 2017
| @@ -1,303 +1,321 @@ | |||
| /* eslint-disable */ | |||
| /** | |||
Collaborator
There was a problem hiding this comment.
nit: small headers now :)
Contributor
Author
There was a problem hiding this comment.
nit: small headers now :)
lulz I was hoping I'd get merged first :)
patrickhulce
approved these changes
Jun 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
default.jswas oncedefault.json, and still has the double quotes to prove it. This updates to remove those, add a license header, enable eslint, and sprinkle in some trailing commas to hopefully help withgit blamein the future while this commit is ruining it in the present :)Disabled
max-lenfor this file because of the description strings and this is a config file, not a normal script file, but happy to turn back on if others want it.part of #2276