fix(anchors-with-no-rel): ignore same origin links#2749
Merged
brendankenny merged 2 commits intomasterfrom Jul 26, 2017
Merged
Conversation
patrickhulce
commented
Jul 26, 2017
| .filter(anchor => { | ||
| try { | ||
| return anchor.href === '' || new URL(anchor.href).host !== pageHost; | ||
| return new URL(anchor.href).host !== pageHost; |
Collaborator
Author
There was a problem hiding this comment.
this check was redundant given the try catch handling
brendankenny
approved these changes
Jul 26, 2017
|
|
||
| if (!(key in actual)) { | ||
| return {keyPath, undefined, expectedValue}; | ||
| return {path: keyPath, actual: undefined, expected: expectedValue}; |
Contributor
There was a problem hiding this comment.
whoops, well that won't work.
({undefined} alone seems like a ridiculous thing that should be caught instead of giving {undefined: undefined} :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2743
we actually already had the smoketest to catch this but it was updated without catching it in review last time, also fixes a rather humorous smokehouse bug where we said
difference at undefined, found undefined but expected undefined