Lighthouse treats "shrink-to-fit" property in meta-tag "viewport" as invalid#2863
Merged
paulirish merged 4 commits intoGoogleChrome:masterfrom Aug 7, 2017
Merged
Lighthouse treats "shrink-to-fit" property in meta-tag "viewport" as invalid#2863paulirish merged 4 commits intoGoogleChrome:masterfrom
paulirish merged 4 commits intoGoogleChrome:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
Member
|
The package.json change looks great, but the yarn.lock diff is much bigger than i'd expect. want to try that part again? |
Contributor
Author
|
Hey @paulirish, thanks to check it out. It's fixed |
paulirish
approved these changes
Aug 7, 2017
Member
|
thanks very much for making this happen in both projects! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2474