Skip to content

Lighthouse treats "shrink-to-fit" property in meta-tag "viewport" as invalid#2863

Merged
paulirish merged 4 commits intoGoogleChrome:masterfrom
hmelenok:master
Aug 7, 2017
Merged

Lighthouse treats "shrink-to-fit" property in meta-tag "viewport" as invalid#2863
paulirish merged 4 commits intoGoogleChrome:masterfrom
hmelenok:master

Conversation

@hmelenok
Copy link
Contributor

@hmelenok hmelenok commented Aug 7, 2017

Fix for #2474

screen shot 2017-08-07 at 12 33 34

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@hmelenok
Copy link
Contributor Author

hmelenok commented Aug 7, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@paulirish
Copy link
Member

The package.json change looks great, but the yarn.lock diff is much bigger than i'd expect.

want to try that part again?

@hmelenok
Copy link
Contributor Author

hmelenok commented Aug 7, 2017

Hey @paulirish, thanks to check it out. It's fixed

@paulirish
Copy link
Member

thanks very much for making this happen in both projects!

@paulirish paulirish merged commit e1a04dd into GoogleChrome:master Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants