misc(audits): removed unused audit meta.category#3554
Merged
brendankenny merged 2 commits intoGoogleChrome:masterfrom Oct 18, 2017
arturmiz:remove-audit.meta.category
Merged
misc(audits): removed unused audit meta.category#3554brendankenny merged 2 commits intoGoogleChrome:masterfrom arturmiz:remove-audit.meta.category
brendankenny merged 2 commits intoGoogleChrome:masterfrom
arturmiz:remove-audit.meta.category
Conversation
ISSUES CLOSED: 3252
Member
|
Hero! |
Collaborator
|
amazing! 👏 |
brendankenny
suggested changes
Oct 18, 2017
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
Looks like that search work wasn't trivial :) Thanks!
I only see the one issue and one more thing that can be deleted, otherwise looking good
| const diff = findDifference(auditName, actualResult, expectedResult); | ||
|
|
||
| return { | ||
| category: auditName, |
Contributor
There was a problem hiding this comment.
the two in this file are a different category and should stay :)
| audits: [basePath + '/missing-audit'], | ||
| }), /audit\(\) method/); | ||
|
|
||
| assert.throws(_ => new Config({ |
Contributor
There was a problem hiding this comment.
will you also delete the file this was loading (lighthouse-core/test/fixtures/invalid-audits/missing-category.js)
Contributor
|
one more in lighthouse/lighthouse-cli/types/types.ts Line 23 in 487bee6 |
arturmiz
requested review from
patrickhulce,
paulirish and
vinamratasingal-zz
as code owners
Contributor
Author
|
@brendankenny code review fixes applied 👍 |
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM thanks for the work here!
patrickhulce
approved these changes
Oct 18, 2017
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3252