docs(readme): add MagicLight WebBLE integration#3613
Merged
brendankenny merged 3 commits intoGoogleChrome:masterfrom Oct 31, 2017
Merged
docs(readme): add MagicLight WebBLE integration#3613brendankenny merged 3 commits intoGoogleChrome:masterfrom
brendankenny merged 3 commits intoGoogleChrome:masterfrom
Conversation
paulirish
reviewed
Oct 18, 2017
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
i think you mean https://github.com/manekinekko/lighthouse-magic-light/tree/web-ble ?
or you should probably just merge that branch to master
i would also update your readme.
v cool tho!
readme.md
Outdated
| * **[lighthouse-mocha-example](https://github.com/justinribeiro/lighthouse-mocha-example)** - gather performance metrics via Lighthouse and tests them in Mocha | ||
| * **[pwmetrics](https://github.com/paulirish/pwmetrics/)** - gather performance metrics | ||
| * **[lighthouse-hue](https://github.com/ebidel/lighthouse-hue)** - set the color of Philips Hue lights based on a Lighthouse score | ||
| * **[lighthous-magic-light](https://github.com/manekinekko/lighthouse-magic-light)** set the color of the MagicLight Bluetooth Smart Light Bulb based on Lighthouse score |
Member
There was a problem hiding this comment.
wanna add 3 spaces at the start to indent this under lighthouse-hue since they're buddies?
Author
|
Sure. Will do that. |
devtools-bot
added
waiting4reviewer
and removed
waiting4committer
waiting4reviewer
labels
brendankenny
suggested changes
Oct 20, 2017
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
Can you also update the README on the project? Going in there users might miss the updates and only see the references to Phillips Hue in the readme.
Author
|
@paulirish @brendankenny I update my project on master. Everything should be OK now. Lmk. |
brendankenny
approved these changes
Oct 31, 2017
Contributor
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your patience
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.