docs(new-audits.md): Docs on new audits#3617
Merged
Conversation
paulirish
requested changes
Nov 3, 2017
Member
paulirish
left a comment
paulirish
left a comment
There was a problem hiding this comment.
I think we want to add something like "What do you propose for the audit's report UI?" or there may be multiple proposals.., but we want to understand this fairly early.
Also... perhaps we could also ask them to provide any links with more information about the particular issue & recommendation.
docs/new-audits.md
Outdated
|
|
||
| *Note: it's possible to submit a new audit proposal for something that you as a contributor feel very passionate about, but the | ||
| Lighthouse team feels that it wouldn't add value to a significant portion of the Lighthouse users. In this case, we'd be open to | ||
| having your audit be a part of the report when run with the full config on the Command Line. * |
Member
There was a problem hiding this comment.
nuke the space before your last * to get the italics
docs/new-audits.md
Outdated
| having your audit be a part of the report when run with the full config on the Command Line. * | ||
|
|
||
| ## Process for creating a new audit | ||
| - Briefly scan the criteria we’ve laid out above. If you think the principles match with your proposed new audit, then proceed! |
Member
There was a problem hiding this comment.
lets use numbered bullets for this one instead ? you can just use 1. every time (and it'll increment)
added Paul changes.
paulirish
approved these changes
Nov 4, 2017
christhompson
pushed a commit
to christhompson/lighthouse
that referenced
this pull request
Nov 28, 2017
ghost
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2624