Skip to content

report(perf-audits): adjust presentation of runtime cost audits#4020

Merged
paulirish merged 3 commits intomasterfrom
breakdownrawvalue
Dec 11, 2017
Merged

report(perf-audits): adjust presentation of runtime cost audits#4020
paulirish merged 3 commits intomasterfrom
breakdownrawvalue

Conversation

@paulirish
Copy link
Member

I noticed and fixed some inconsistencies

  • main thread work breakdown was always showing in diagnostics, even if total cost was just 40ms.
  • bootup time audit was saying "is high" but only when the audit was passing.
  • now the failure threshold for the two audits is adjusted.
    • just JS bootup times costing more than 2s, show it. total main thread time costing more than 4s, show that.

@vinamratasingal-zz
Copy link

Silly question- are there any UX changes to the report itself? Otherwise, I don't have any input on the logic changes.

@paulirish
Copy link
Member Author

  • i'm changing when both audits show up vs get put into "Passed Audits"
  • The title of "JavaScript boot-up time is high (> 4s)" (which you see in the report), i'm changing to just "JavaScript boot-up time".

@vinamratasingal-zz
Copy link

LGTM

@paulirish paulirish merged commit f49ef06 into master Dec 11, 2017
@paulirish paulirish deleted the breakdownrawvalue branch December 11, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants