core(config): show SEO audits in the UI

[kdzwinel]

Latest copy taken from the "Lighthouse SEO Audit Text" doc.

Tested in the extension:

---

---

I made sure that all "learn more" links work and link to the right docs (that's how I found that one of the links was broken ).

Closes #3772

[rviscomi]

👍

[kdzwinel]

BTW http://gooleisnotgoogle.weebly.com/

[kdzwinel]

Hm… I wonder why these groups are not shown in the report as they are in e.g. accessibility:

[patrickhulce]

a11y category has its own render logic at the moment, we'll need to refactor to make it part of default logic to render groups if they're present :)

lighthouse/lighthouse-core/report/v2/renderer/category-renderer.js

Lines 440 to 461 in 9ef858a

	_renderAccessibilityCategory(category, groupDefinitions) {
	const element = this._dom.createElement('div', 'lh-category');
	this._createPermalinkSpan(element, category.id);
	element.appendChild(this._renderCategoryScore(category));
	const manualAudits = category.audits.filter(audit => audit.result.manual);
	const nonManualAudits = category.audits.filter(audit => !manualAudits.includes(audit));
	const auditsGroupedByGroup = /** @type {!Object<string,
	{passed: !Array<!ReportRenderer.AuditJSON>,
	failed: !Array<!ReportRenderer.AuditJSON>}>} */ ({});
	nonManualAudits.forEach(audit => {
	const groupId = audit.group;
	const groups = auditsGroupedByGroup[groupId] || {passed: [], failed: []};
	if (audit.score === 100) {
	groups.passed.push(audit);
	} else {
	groups.failed.push(audit);
	}
	auditsGroupedByGroup[groupId] = groups;
	});

[kdzwinel]

I missed that require('url').parse won't work in the extension. Thankfully it was easy to replace.

[kdzwinel]

@patrickhulce thanks! I guess we don't want to create another custom renderer ATM? It doesn't make sense to make this refactor here IMO, it deserves its own PR. @rviscomi are we OK with launching w/o the categories?

[rviscomi]

Yes, categories would be great to have but shouldn't block this PR.

[patrickhulce]

that plan sgtm!

@kdzwinel any more changes you'd like to make? if not, this lgtm for initial release!

[kdzwinel]

Sorry that I kept adding stuff after opening the PR. I should have put [WIP] in the title. Anyway, I have nothing more to add here. Thank you for reviewing it!

[patrickhulce]

Sorry that I kept adding stuff after opening the PR. I should have put [WIP] in the title. Anyway, I have nothing more to add here. Thank you for reviewing it!

no worries we all find things after the PR goes up :) this should go out with 2.7 today then!

[kdzwinel]

🎉 Fantastic! Thanks a bunch.