Conversation
Contributor
|
@paulirish thanks. I see it's already logging to a "status" logger, which I think I can catch by inspecting its output. Will play with it. |
Contributor
|
I think I'll want to make some UI changes off the back of this, but I'll follow on with a separate PR. Alex, since you're a primary customer of this can you let us know when you've had chance to review the changes? |
Contributor
|
Ah sorry, I already looked at it. Looks great. LGTM from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video: https://gfycat.com/RequiredLinearDalmatian
This exposes events on
log.evthat you anyone can add listeners to.@crhym3 I don't think this'll give you everything you need, but maybe you can add a CLI flag to ship progress data another way?