Conversation
Contributor
|
I'm not clear on exactly what the change proposes. How does computedArtifacts sit alongside artifacts? |
Member
Author
|
#542 has some backstory, but I'll elaborate here. This was motivated by two things:
This PR makes a semantic change between these two categories.
And lastly, functionally, this PR adds an async interface onto the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few in-between artifacts that have been generated from the trace & networkRecords. However they can be lazily created, which simplifies the scheduling of items like speedline, and reduces complexity when importing artifacts from the config.
Additionally, this also means we can cache the results of our computedArtifacts, which will speed up generation of
speedline,DevtoolsTimelineModel, andTracingModel.This PR moves 3 gatherers into be computedArtifacts:
speedline,screenshots, andcritical network chains.Once landed, I'll followup with porting
DevtoolsTimelineModel, andTracingModelinto the same setup. (With the latest version of speedline, we can now pass a completeDevtoolsTimelineModelinto it, the same we'll share for our own measurements. This will take care of another ~1-4s of latency during reporting)fixes #542