Skip to content
This repository was archived by the owner on Oct 6, 2022. It is now read-only.

[FEATURE] Allow setting specific javascriptQuerySelectors so you coul…#654

Closed
lewisvoncken wants to merge 3 commits into
GoogleChrome:mainfrom
experius:feature/javascriptQuerySelector
Closed

[FEATURE] Allow setting specific javascriptQuerySelectors so you coul…#654
lewisvoncken wants to merge 3 commits into
GoogleChrome:mainfrom
experius:feature/javascriptQuerySelector

Conversation

@lewisvoncken
Copy link
Copy Markdown

…d also prevent stripping javascript tags

@lewisvoncken lewisvoncken requested a review from AVGP as a code owner March 28, 2021 12:57
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Mar 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@lewisvoncken
Copy link
Copy Markdown
Author

@googlebot I signed it!

@lewisvoncken lewisvoncken force-pushed the feature/javascriptQuerySelector branch from 05ffa90 to 62360a0 Compare March 28, 2021 13:06
lewisvoncken added a commit to experius/pwa-studio that referenced this pull request Mar 28, 2021
lewisvoncken added a commit to experius/pwa-studio that referenced this pull request Mar 29, 2021
@lewisvoncken
Copy link
Copy Markdown
Author

@AVGP do you have any questions about these changes?

lewisvoncken added a commit to experius/pwa-studio that referenced this pull request Apr 9, 2021
lewisvoncken added a commit to experius/pwa-studio that referenced this pull request Apr 9, 2021
lewisvoncken added a commit to experius/pwa-studio that referenced this pull request Apr 9, 2021
lewisvoncken added a commit to experius/pwa-studio that referenced this pull request Apr 9, 2021
lewisvoncken added a commit to experius/SeoSnap-Cache-Server that referenced this pull request Apr 22, 2021
@lewisvoncken lewisvoncken requested a review from aomarks as a code owner April 23, 2021 11:34
@lewisvoncken
Copy link
Copy Markdown
Author

@AVGP I have also added a width/height functionality for the viewport when the mobile parameter is set

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants