Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Validate that Pubsub resource names are at least 3 chars #172

Merged
dhalperi merged 1 commit into from
Mar 29, 2016
Merged

Validate that Pubsub resource names are at least 3 chars #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sdk/src/main/java/com/google/cloud/dataflow/sdk/io/PubsubIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ public class PubsubIO {

private static final Pattern PUBSUB_NAME_REGEXP = Pattern.compile("[a-zA-Z][-._~%+a-zA-Z0-9]+");

private static final int PUBSUB_NAME_MIN_LENGTH = 3;
private static final int PUBSUB_NAME_MAX_LENGTH = 255;

private static final String SUBSCRIPTION_RANDOM_TEST_PREFIX = "_random/";
Expand All @@ -120,6 +121,10 @@ private static void validateProjectName(String project) {
}

private static void validatePubsubName(String name) {
if (name.length() < PUBSUB_NAME_MIN_LENGTH) {
throw new IllegalArgumentException(
"Pubsub object name is shorter than 3 characters: " + name);
}
if (name.length() > PUBSUB_NAME_MAX_LENGTH) {
throw new IllegalArgumentException(
"Pubsub object name is longer than 255 characters: " + name);
Expand Down