This repository was archived by the owner on Nov 11, 2022. It is now read-only.
Use AtomicReference in InProcessSideInputContainer #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a TOCTOU race in the contents updating logic, where the determination that the current pane should replace the contents of the side input and the replacement is not a single atomic operation. Using AtomicReference allows the use of compareAndSet to ensure that the replacement can only occur on the pane that the decision to replace was made with. Fixes a race where a pane could be the latest, and replace a pane, but would be lost due to an earlier pane being written between the invalidation and loading of contents. Fixes a race where a reader can incorrectly read an empty iterable as the contents of a PCollectionView, due to occuring between the invalidate and reload steps.
This ensures that while processing a bundle all elements see the same contents for any SideInput Window.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports Beam #318 and #326