Skip to content

Conversation

@ilya-kozyrev
Copy link
Contributor

@ilya-kozyrev ilya-kozyrev commented Jan 14, 2021

Some users may want to protect their sensitive data using tokenization.
We propose to create a template that will provide integration with protection RPC server using Beam transform to protect sensitive data using tokenization.

At a high level, a template that will:

  • support batch (GCS) and streaming (Pub/Sub) input sources
  • tokenize sensitive data via external RPC service - we are about to use Protegrity
  • output tokenized data into BigQuery, BigTable, or GCS
  • supported formats: CSV and JSON

More details and the proposed design are available in the design doc.

ilya-kozyrev and others added 30 commits November 23, 2020 18:38
…taflowTemplates into ProtegrityIntegrationTemplate
* Added bigtable changes

* Moved BigTable related IO ops to separate package
@google-cla
Copy link

google-cla bot commented May 11, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented May 11, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented May 11, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@RaphaelSanamyan
Copy link

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented May 11, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes The PR submitter has a CLA and removed cla: no The PR submitter does not have a CLA labels May 11, 2021
RaphaelSanamyan and others added 3 commits May 12, 2021 14:47
* add nullable option support into fromJson

* resolve comments

* fix comments
@ilya-kozyrev
Copy link
Contributor Author

@prathapreddy123 We've refactored modules and classes to common that you suggest and changed our code/docs based on your suggestions. Could you please review the changes?

@ilya-kozyrev
Copy link
Contributor Author

Hi @prathapreddy12. Did you have a chance to review our changes?

@prathapreddy123
Copy link
Contributor

Hi @prathapreddy12. Did you have a chance to review our changes?

Hi @ilya-kozyrev - We were currently undergoing through design & refactoring process. It would be helpful to review the template post completion of our design to share latest updates. Expected ETA 2 - 4 weeks.

@ilya-kozyrev
Copy link
Contributor Author

Hi @prathapreddy123 could you please review this PR? If any help from our side is required please let us know.
Thanks in advance

@prathapreddy123 prathapreddy123 requested review from an2x and removed request for prathapreddy123 July 9, 2021 14:42
@prathapreddy123
Copy link
Contributor

Hi @prathapreddy123 could you please review this PR? If any help from our side is required please let us know.
Thanks in advance

@an2x - Can you take care of this request. For context, please refer to earlier comments

@an2x
Copy link
Member

an2x commented Jul 9, 2021

Hi @prathapreddy123 could you please review this PR? If any help from our side is required please let us know.
Thanks in advance

@an2x - Can you take care of this request. For context, please refer to earlier comments

Will do, probably early next week.

@ilya-kozyrev
Copy link
Contributor Author

Hi @an2x, @prathapreddy123. Did you have a chance to review this PR? Can we help with it somehow?

@prathapreddy123
Copy link
Contributor

Hi @an2x, @prathapreddy123. Did you have a chance to review this PR? Can we help with it somehow?

Hi ilya - Sorry for the delay. Several things has changed recently in terms of module structure etc. We will start reviewing in next few days but may take a while to complete(ETA: couple of weeks).

@ilya-kozyrev
Copy link
Contributor Author

Hi @prathapreddy123 @an2x. We are looking forward to your reviewing. We believe that our improvements could be helpful for the community. If we can help somehow with merging this PR, please free to ask.

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@bvolpato
Copy link

Hi @ilya-kozyrev -- thanks for your contribution here. Unfortunately we ran behind on reviews, and the structure of the project changed a bit. Is there still interest in pursuing this template? We can work together on a plan to resolve conflicts + review the code.

@stale stale bot removed the stale label Jun 22, 2023
@bvolpato
Copy link

Closing this because it got stale for a few months. Please rebase / file a new one to bring it up to the top of the stack.

@bvolpato bvolpato closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes The PR submitter has a CLA

Projects

None yet

Development

Successfully merging this pull request may close these issues.