Skip to content
This repository was archived by the owner on Mar 17, 2022. It is now read-only.

Conversation

@steffnay
Copy link
Contributor

@steffnay steffnay commented Oct 24, 2018

Fixes #23

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@jmdobry jmdobry changed the title [DO NOT MERGE] Functions Add Cloud Functions Oct 24, 2018
@jmdobry jmdobry requested a review from ace-n October 24, 2018 20:21
@codecov
Copy link

codecov bot commented Oct 24, 2018

Codecov Report

Merging #24 into master will decrease coverage by 0.31%.
The diff coverage is 98.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   98.98%   98.67%   -0.32%     
==========================================
  Files           1        4       +3     
  Lines          99      227     +128     
==========================================
+ Hits           98      224     +126     
- Misses          1        3       +2
Impacted Files Coverage Δ
system-test/functions_system_test.js 100% <100%> (ø)
src/util.js 99% <100%> (+0.01%) ⬆️
system-test/issuePayload.js 100% <100%> (ø)
functions/index.js 96.72% <96.72%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c92c9cd...67cde48. Read the comment docs.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than a few nits.

src/util.js Outdated
function getIssueInfo(issue) {
try {
const text = issue.title + ' ' + issue.body;
const raw = issue.title + ' ' + issue.body;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a spot? 😛

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants