remove libraries.json and related classes. #899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loosebazooka
approved these changes
Sep 13, 2022
Contributor
loosebazooka
left a comment
loosebazooka
left a comment
There was a problem hiding this comment.
I know I'm not working on this project anymore, but I love a good PR with only deletions.
elefeint
approved these changes
Sep 13, 2022
Contributor
|
Not sure if you missed my message in the email thread, but the file is being used by CT4E. |
Contributor
|
I did miss it :( I was hoping CT4E was also using DRIFT metadata, as is proper. I'll look into it. |
Contributor
|
does CT4E still have an owner? @briandealwis |
Contributor
|
@zhumin8 Unfortunately, it meas we'll have to fix up the broken links and leave the metadata for now. Or else, redo the Eclipse tool to use DRIFT, which is likely more work. |
Contributor
|
@loosebazooka @briandealwis Cloud Java owns CT4E, so I am it, technically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per separate discussion, removing
libraries.jsonand related classes that's not used anymore.