This repository was archived by the owner on Apr 13, 2022. It is now read-only.
Gcloud use java repo tools #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds shared pom.xml and google-checks.xml. I also add a test directory to check that the pom works / is well-formed.
Add Travis configuration.
Remove unnecessary properties.
Ignore JavaDoc rules in test classes.
Ignore service account file.
Remove extra XML stuff from POM.
Subtrees are the primary way I expect people to use the `java-repo-tools` repository. Since it's not a super common workflow, I document the needed steps in the README.
Add instructions for using with subtrees.
I modify the checkstyle config to have SAME_PACKAGE imports appear before third-party imports. I think this better matches the intent of the import ordering rules in the style guide. https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing Expecially since it says the `com.google` imports only appear after static imports if the source file is in the `com.google` package space. (cherry picked from commit 7ca0e7564d4d1a39714d8c90e71d5e408f30f4da)
Checkstyle: have SAME_PACKAGE imports appear before third-party imports
The pulling changes from Java Repository Tools instructions can now be followed verbatim.
The instructions here are much easier to follow and avoid unnecessary conflicts: https://help.github.com/articles/about-git-subtree-merges/
Uses shared https://github.com/GoogleCloudPlatform/java-repo-tools to configure checkstyle and test plugins. Merge remote-tracking branch 'java-repo-tools/master' into use-java-repo-tools
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
Lint the getting started sample.
Contributor
|
Please update to 1.9.34 |
Contributor
|
LGTM |
tswast
force-pushed
the
gcloud-use-java-repo-tools
branch
from
82bd4e8 to
978e550
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge in change to lint samples into gcloud branch.
See #7 for master.
CC @ludoch