fix: add "disks" mandatory argument#26
Merged
aaronegolden merged 1 commit intoGoogleCloudPlatform:mainfrom Jun 26, 2024
Merged
Conversation
bolianyin
approved these changes
Sep 27, 2023
aaronegolden
approved these changes
Jun 26, 2024
Collaborator
aaronegolden
left a comment
aaronegolden
left a comment
There was a problem hiding this comment.
Strictly speaking /disks shouldn't be required unless the job runs on COS, where /mnt itself isn't writeable but /mnt/disks is. I agree it's a good habit to use /mnt/disks though, for the times when you might be trying out different configuration and switching back and forth between COS and other systems. It's a pain to update mount paths so just use the everywhere-compatible path to begin with.
gooleg-gh
added a commit
to gooleg-gh/batch-samples
that referenced
this pull request
Jan 2, 2026
The GoogleCloudPlatform#26 replaced `/mnt/share` with `/mnt/disks/share` in `job.json`, but not in the `transcode.sh`. This results in job failing as it is unable to find the input files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.