fix: remove spurious 'install' package name from pip command#89
Merged
wenyhu-google merged 1 commit intoGoogleCloudPlatform:mainfrom Mar 25, 2026
Conversation
Contributor
Author
|
@wenyhu-google can you review please? |
wenyhu-google
approved these changes
Mar 25, 2026
Contributor
Author
|
@wenyhu-google looks like a repo owner needs to merge this too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPU training Dockerfile contains a duplicated
installkeyword that pip interprets as a package name:RUN pip3 install install torchvision pillowinstallis not registered on PyPI. An attacker who registers the name at any version will have their package fetched and executed during container build — as root, inside an NVIDIA CUDA environment with access to build credentials and any service account tokens available to the Docker daemon.This PR removes the extraneous
installargument, correcting the command to:RUN pip3 install torchvision pillow