Fix a crash in Java agent when gRPC context is cancelled before the first call is made. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalyanac
approved these changes
Aug 12, 2019
cloud-profiler-github-robot
force-pushed
the
test_262839211
branch
from
32df4f1 to
ea0564f
Compare
PiperOrigin-RevId: 262978966
cloud-profiler-github-robot
force-pushed
the
test_262839211
branch
from
ea0564f to
29dd27c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash in Java agent when gRPC context is cancelled before the first call is made.
This is not related to #14, I just noticed it when playing with that. Example crash is below.
Manual failing run with the OSS agent:
$ java -agentpath:./profiler_java_agent.so
Usage: java [-options] class [args...]
(to execute a class)
or java [-options] -jar jarfile [args...]
(to execute a jar file)
where options include:
-server to select the "server" VM
The default VM is server,
because you are running on a server-class machine.