Update Java profiling agent to the latest version #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 289930597
PiperOrigin-RevId: 291229124
…d::basic_string.
Adding these qualifications will make google3 C++ more portable, allow the global using std::string declarations in the google3 copy of the C++ standard library to be deleted, and bring google3 C++ in line with how the rest of the world uses C++. This completes the work started in go/lsc-add-std and go/std-type-qualification.
LSC documentation: go/lsc-std-string
Tested:
tap_presubmit: http://test/OCL:295966075:BASE:296180783:1582224434355:a04fbb44
Some tests failed; test failures are believed to be unrelated to this CL
PiperOrigin-RevId: 296808824
PiperOrigin-RevId: 298470814
PiperOrigin-RevId: 299228617
PiperOrigin-RevId: 304565178
….66.0 to build Java agent. PiperOrigin-RevId: 304959666
PiperOrigin-RevId: 308660276
PiperOrigin-RevId: 310472078
PiperOrigin-RevId: 311236078
…o 3.11. PiperOrigin-RevId: 314174911
kalyanac
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TESTED: Ran
./build.shand ran application with agent locally to validated that the agent could be used to collect profiles (CPU, wall, and heap) and that those profiles were approximately the same as those collected by the agent downloaded from the GCS bucket.TODO: Ran
./build.sh -aand deployed application to GKE (with alpine docker image) to validate the agent could be used to collect profiles and that those profiles were approximately the same as those collected by the agent downloaded from the GCS bucket.