Copybara staging #28
Merged
Copybara staging #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 315570026
PiperOrigin-RevId: 316166010
There is still some Sawzall code running in production as a business logic execution engine in GMail and Gaia. We need to manually finish the proto2 conversion in order to release a new Sawzall binary that is compatible with new changes to protocol buffers.
More information: go/sawzall-proto2-lsc and go/sawzall-proto2
Tested:
tap_presubmit: http://test/OCL:315701415:BASE:316210669:1592040780158:d61d033f
Some tests failed; test failures are believed to be unrelated to this CL
PiperOrigin-RevId: 316462109
*** Reason for rollback ***
This CL includes a proto that is compiled with the open source compiler that does not understand szl_api_version. I believe I need to do something like cl/316423607 for at least one of the proto files involved. For now, let's roll back in order to not inconvenience the team.
*** Original change description ***
Explicitly set szl_api_version = 2.
There is still some Sawzall code running in production as a business logic execution engine in GMail and Gaia. We need to manually finish the proto2 conversion in order to release a new Sawzall binary that is compatible with new changes to protocol buffers.
More information: go/sawzall-proto2-lsc and go/sawzall-proto2
Tested:
tap_presubmit: http://test/OCL:315701415:BASE:316210669:1592040780158:d61d033f
Some tests failed; test failures are beli...
***
PiperOrigin-RevId: 316652609
PiperOrigin-RevId: 316695088
PiperOrigin-RevId: 316778235
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TESTED:
sh build.shand confirmed agent collected CPU, heap, and wall profiles when run with local application. Also confirmed agent logged version github:89347b95addb400a18ee8ed4862813d88759f634.sh build.sh -aand confirmed agent collected CPU, heap, and wall profiles when run in GKE. Also confirmed agent logged version github_alpine:89347b95addb400a18ee8ed4862813d88759f634.