Skip to content

Conversation

@leslieluyu
Copy link

fix the bug #48
it's a logical error,
should use Logical and (&&) instead of Logical or (||) between two negative condition:

if [[ "${MACHINE_TYPE}" != "aarch64" ]] && [[ "${MACHINE_TYPE}" != "arm64" ]]

fix the bug GoogleCloudPlatform#48
it's a logical error
@google-cla
Copy link

google-cla bot commented Jul 4, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@leslieluyu leslieluyu changed the title Update build.sh Fix the logical error of arm64 in build.sh Jul 4, 2022
@punya
Copy link
Contributor

punya commented Sep 15, 2022

@leslieluyu thanks for creating the issue. Unfortunately we are not able to merge PRs from outside contributors at the moment (this repository is a mirror of a Google-internal repo that's used for active development). We'll look into this problem as part of the larger topic of ARM64 support.

@punya punya closed this Sep 15, 2022
punya added a commit that referenced this pull request Mar 17, 2023
Credit to @leslieluyu for the contribution in #49.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants