ci: new jobs image publishing configuration#85
Merged
Conversation
iennae
approved these changes
Mar 15, 2024
iennae
left a comment
iennae
left a comment
There was a problem hiding this comment.
LGTM; thanks for the detailed description of what is intended by the changes proposed.
danistrebel
pushed a commit
to danistrebel/cloud-run-hello
that referenced
this pull request
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this PR
scriptsyntaxFor comparison, see https://github.com/GoogleCloudPlatform/cloud-run-hello/blob/master/testing/jobs.merge.cloudbuild.yaml
Why a new file?
This change keeps the existing build config during a transition period, and comments the file to that purpose.
Why multiple changes in one PR
If someone wants I can break it up, but before arriving at this simple set of changes, I explored if this configuration should be made generic across the repository. Landing back on looks like several small changes but in fact is a re-simplification from a significant overhaul.