feat(ci): Add image build and publish configs for sample services#89
Merged
Conversation
glasnt
approved these changes
Apr 3, 2024
|
s/The code for these 3 workloads is effectively two codebases./The code in this repository is inconsistently organized./ |
danistrebel
pushed a commit
to danistrebel/cloud-run-hello
that referenced
this pull request
Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change brings the configuration of the container image build pipeline into the repository, and creates space for further customizations later.
Decision: cloudbuild.yaml per container build
Context
This repository hosts three apps that need to be built and published with a container image. This codebase is inconsistently organized, with two workloads tangled at the root directory and a third in a dedicated subdirectory.
hello-jobis injob/helloandplaceholderare at the repository rootThe services at the root share Go code for a web server and they cannot be separated without code duplication or further refactoring.
This means we have three very similar cloudbuild.yaml configurations, two of which are targeting the same build directory.
Options
helloandplaceholderservices it will require careful refactoring or split up of a the pipeline configuration.Revisiting
If the configurations grow significantly with common configurations, that may be grounds to combine them, but there are alternatives such as adding a reusable shell script to the repository that could be called from each separate configuration.