fix local development with the Pub/Sub emulator#98
Merged
matthewrobertson merged 2 commits intomasterfrom Jul 7, 2021
Merged
Conversation
matthewrobertson
force-pushed
the
fix-pubsub-emulator
branch
from
37320bc to
176b4b7
Compare
eamonnmcmanus
requested changes
Jun 28, 2021
Member
eamonnmcmanus
left a comment
eamonnmcmanus
left a comment
There was a problem hiding this comment.
Looks like the conformance tests are failing?
Member
Author
|
That's weird. It looks like it is using the wrong version of the conformance tests. The declared version of the action is v0.3.9 but it is actually using v0.3.12.
My guess is this is a bug with using different version of the same action in a single workflow. I needed to put up fix for these conversions anyway... |
matthewrobertson
force-pushed
the
fix-pubsub-emulator
branch
from
176b4b7 to
9b94843
Compare
Member
Author
|
rebase seems to have fixed the issue |
eamonnmcmanus
requested changes
Jun 30, 2021
Member
eamonnmcmanus
left a comment
eamonnmcmanus
left a comment
There was a problem hiding this comment.
This looks fine, apart from some style nits.
invoker/core/src/main/java/com/google/cloud/functions/invoker/Event.java
Outdated
Show resolved
Hide resolved
...er/core/src/test/java/com/google/cloud/functions/invoker/BackgroundFunctionExecutorTest.java
Outdated
Show resolved
Hide resolved
...er/core/src/test/java/com/google/cloud/functions/invoker/BackgroundFunctionExecutorTest.java
Outdated
Show resolved
Hide resolved
...er/core/src/test/java/com/google/cloud/functions/invoker/BackgroundFunctionExecutorTest.java
Outdated
Show resolved
Hide resolved
Currently, the functions frameworks are dependent on some private dataplane event marshalling logic in order to correctly pass PubSub events to background functions. This commit implements the same marshalling logic in the FF in order to enable local development using the PubSub emulator. We have already made this change in other languages: GoogleCloudPlatform/functions-framework-nodejs#272 GoogleCloudPlatform/functions-framework-ruby#100 GoogleCloudPlatform/functions-framework-python#121 GoogleCloudPlatform/functions-framework-go#70
matthewrobertson
force-pushed
the
fix-pubsub-emulator
branch
from
9b94843 to
dec93ac
Compare
eamonnmcmanus
approved these changes
Jul 7, 2021
This was referenced Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the functions frameworks are dependent on some private
dataplane event marshalling logic in order to correctly pass PubSub
events to background functions. This commit implements the same
marshalling logic in the FF in order to enable local development using
the PubSub emulator.
We have already implemented this change in other function frameworks:
GoogleCloudPlatform/functions-framework-nodejs#272
GoogleCloudPlatform/functions-framework-ruby#100
GoogleCloudPlatform/functions-framework-python#121
GoogleCloudPlatform/functions-framework-go#70