Skip to content

docs: Fixed wrong function URL in README#140

Closed
crmne wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
crmne:master
Closed

docs: Fixed wrong function URL in README#140
crmne wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
crmne:master

Conversation

@crmne
Copy link

@crmne crmne commented Jul 27, 2021

A simple pull request that fixes the problem I had while trying cloud functions locally that connect to the pubsub emulator.

Before, it used to point the subscription to the pubsub emulator itself, instead of the cloud function endpoint.

@google-cla
Copy link

google-cla bot commented Jul 27, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jul 27, 2021
@crmne
Copy link
Author

crmne commented Jul 27, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Jul 27, 2021
@di di changed the title Fixed wrong function URL in README docs: Fixed wrong function URL in README Jul 27, 2021
@di
Copy link
Member

di commented Jul 27, 2021

@anguillanneuf Can you review?

@crmne You'll need to add docs: to your commit message to get the "Conventional Commits" check to pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants