Add Cloud Tasks Readmes#1156
Merged
dzlier-gcp merged 3 commits intoGoogleCloudPlatform:masterfrom Jul 17, 2018
Merged
Conversation
googlebot
added
the
cla: yes
Contributor
Author
|
\assign dzlier-gcp |
dzlier-gcp
previously approved these changes
Jul 16, 2018
Member
dzlier-gcp
left a comment
dzlier-gcp
left a comment
There was a problem hiding this comment.
This is good work on short notice, thanks for filling in the gaps.
appengine-java8/tasks/README.md
Outdated
| export LOCATION_ID=us-central1 | ||
| ``` | ||
|
|
||
| Create a task, targeted at the `log_payload` endpoint, with a payload specified: |
Member
There was a problem hiding this comment.
Won't affect execution since the CreateTask class has it correct, but the endpoint should be 'tasks/create' here like you have below. Because it's important to be different from python.
appengine-java8/tasks/README.md
Outdated
| First, your project ID: | ||
|
|
||
| ``` | ||
| export PROJECT_ID=my-project-id |
Member
There was a problem hiding this comment.
We tend to prefer GOOGLE_CLOUD_PROJECT because gcloud will (sometimes) set this up for us, and then the "project" or "project-id" parameter can be omitted from some requests.
tasks/README.md
Outdated
| Optionally, you can set up your settings as environment variables: | ||
|
|
||
| ``` | ||
| export PROJECT_ID=<YOUR_PROJECT_ID> |
Member
There was a problem hiding this comment.
Same as above re: GOOGLE_CLOUD_PROJECT.
dzlier-gcp
reviewed
Jul 17, 2018
appengine-java8/tasks/README.md
Outdated
| Verify the index page is serving: | ||
|
|
||
| ``` | ||
| gcloud app browse |
Member
There was a problem hiding this comment.
Problem: this application doesn't have a base GET handler that would accept requests to the base path on either one, so that would need to be added. It would be pretty trivial to add a "hello world" message on get. If that is what you want to do, just let me know and I could add a commit to do that. Otherwise, we would just need to remove the "verify the index page is serving" step, since the app works without that needing to occur and it's just a sanity checking step for the user.
dzlier-gcp
approved these changes
Jul 17, 2018
minherz
pushed a commit
that referenced
this pull request
Nov 16, 2022
…1156) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `24.4.0` -> `25.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).
minherz
pushed a commit
that referenced
this pull request
Nov 17, 2022
…1156) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `24.4.0` -> `25.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
](https://renovatebot.com){kind=link}
…1156) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `24.4.0` -> `25.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.