Add Cloud SQL Postgres connectivity sample for servlets. #1255
Merged
Add Cloud SQL Postgres connectivity sample for servlets. #1255
Conversation
googlebot
added
the
cla: yes
lesv
approved these changes
Nov 7, 2018
Contributor
lesv
left a comment
lesv
left a comment
There was a problem hiding this comment.
- I hate that you have to specify things twice. That never goes well for me.
(The alternative however is way too convoluted). - If I haven't mentioned it before, voting / counting apps can be problematic at times.
That said it all looks very nice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #1231, but for PostgreSQL.
Corrects some of the region tags to be MySQL-specific (these are pretty much the same for Java, but vary in some languages so separate region tags are needed).