This repository was archived by the owner on Apr 19, 2026. It is now read-only.
Added Custom Recordable Implementation and Unit Tests#2
Merged
IlyaKobelevskiy merged 4 commits intoJul 2, 2020
Conversation
pyohannes
approved these changes
Jul 1, 2020
pyohannes
left a comment
pyohannes
left a comment
There was a problem hiding this comment.
That looks good and is true to the Recordable intention.
pyohannes
approved these changes
Jul 1, 2020
pyohannes
approved these changes
Jul 1, 2020
IlyaKobelevskiy
suggested changes
Jul 2, 2020
ZiweiZhao
approved these changes
Jul 2, 2020
|
|
||
| const std::chrono::nanoseconds start_time_nanos(reinterpret_cast<int32_t>(rec.span().start_time().nanos())); | ||
| const std::chrono::seconds start_time_seconds(reinterpret_cast<int64_t>(rec.span().start_time().seconds())); | ||
| const std::chrono::nanoseconds unix_start_time(std::chrono::duration_cast<std::chrono::nanoseconds>(start_time_seconds).count() |
There was a problem hiding this comment.
Nit: I'm not sure if OpenTel has a specification on line length, if there is not, I would suggest 80 chars per line.
Contributor
Author
There was a problem hiding this comment.
Thanks! I'll try adjusting to 80 chars wherever I can.
But in some places, I believe this adjustment might affect the readability.
IlyaKobelevskiy
approved these changes
Jul 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a custom Recordable implementation pertaining to the Google Cloudtrace V2 API Spans.
Attributes were recently added in the opentelemtry-cpp repo (Attributes PR), and accordingly I have implemented the
SetAttributemethod to handle them.This will need to be updated gradually as more span data is added to the opentelemetry-cpp repo.