Delete unused logback xml from instrumentation quickstart#333

Merged

aabmass merged 1 commit intoGoogleCloudPlatform:mainfrom

aabmass:cleanup-logback

Jul 17, 2024

Contributor

aabmass commented Apr 19, 2024

This is no longer used since we switched the sample over to log4j2 in #330

The snippet that was here is not used in the docs anymore:


          Delete unused logback xml from instrumentation quickstart

5ebc445

aabmass added the snippet-bot:force-run label

snippet-bot bot removed the snippet-bot:force-run label

snippet-bot bot commented Apr 19, 2024

Here is the summary of changes.

You are about to delete 1 region tag.

examples/instrumentation-quickstart/src/main/resources/logback.xml:19, tag opentelemetry_instrumentation_logbackxml

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

Contributor Author

aabmass commented Apr 22, 2024

Just waiting for the usage of the old snippet to be removed from the internal doc sources

Contributor Author

aabmass commented Jul 16, 2024

Just waiting for the usage of the old snippet to be removed from the internal doc sources

It doesn't seem like it's going to happen. I think we are good to move forward with this PR

aabmass marked this pull request as ready for review

July 16, 2024 20:28

aabmass requested a review from a team as a code owner

July 16, 2024 20:28

dashpole approved these changes

View reviewed changes

aabmass merged commit 72a456e into GoogleCloudPlatform:main

aabmass deleted the cleanup-logback branch

July 17, 2024 14:55

lqiu96 referenced this pull request in googleapis/sdk-platform-java


          deps: update google.cloud.opentelemetry.version to v0.32.0 (#3225)

69e3e38

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[com.google.cloud.opentelemetry:detector-resources-support](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java)
| `0.31.0` -> `0.32.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud.opentelemetry:detector-resources-support/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud.opentelemetry:detector-resources-support/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud.opentelemetry:detector-resources-support/0.31.0/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud.opentelemetry:detector-resources-support/0.31.0/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[com.google.cloud.opentelemetry:shared-resourcemapping](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java)
| `0.31.0` -> `0.32.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud.opentelemetry:shared-resourcemapping/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud.opentelemetry:shared-resourcemapping/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud.opentelemetry:shared-resourcemapping/0.31.0/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud.opentelemetry:shared-resourcemapping/0.31.0/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
|
[com.google.cloud.opentelemetry:exporter-metrics](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java)
| `0.31.0` -> `0.32.0` |
[![age](https://developer.mend.io/api/mc/badges/age/maven/com.google.cloud.opentelemetry:exporter-metrics/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/maven/com.google.cloud.opentelemetry:exporter-metrics/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/maven/com.google.cloud.opentelemetry:exporter-metrics/0.31.0/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/maven/com.google.cloud.opentelemetry:exporter-metrics/0.31.0/0.32.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>GoogleCloudPlatform/opentelemetry-operations-java
(com.google.cloud.opentelemetry:detector-resources-support)</summary>

###
[`v0.32.0`](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/releases/tag/v0.32.0)

[Compare
Source](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/compare/v0.31.0...v0.32.0)

##### Release Highlights

- Enables detection of Cloud Run Jobs environment in GCP resource
detector.

##### What's Changed

- Delete unused logback xml from instrumentation quickstart by
[@&#8203;aabmass](https://redirect.github.com/aabmass) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/333](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/333)
- Upgrade to latest nebula-release plugin to fix build by
[@&#8203;aabmass](https://redirect.github.com/aabmass) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/362](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/362)
- Migrate e2e tests Container Registry usage to Artifact Registry by
[@&#8203;aabmass](https://redirect.github.com/aabmass) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/360](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/360)
- Update the collector image used in instrumentation quickstart by
[@&#8203;aabmass](https://redirect.github.com/aabmass) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/364](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/364)
- Rename spring example by
[@&#8203;psx95](https://redirect.github.com/psx95) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/367](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/367)
- Add manually instrumented spring sample by
[@&#8203;psx95](https://redirect.github.com/psx95) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/368](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/368)
- Update metrics example by
[@&#8203;psx95](https://redirect.github.com/psx95) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/370](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/370)
- Fix the sample code shown in README by
[@&#8203;psx95](https://redirect.github.com/psx95) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/373](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/373)
- Support cloud run jobs in resource detection by
[@&#8203;psx95](https://redirect.github.com/psx95) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/371](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/371)
- Remove obsolete TODO comment by
[@&#8203;psx95](https://redirect.github.com/psx95) in
[https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/374](https://redirect.github.com/GoogleCloudPlatform/opentelemetry-operations-java/pull/374)

**Full Changelog**:
GoogleCloudPlatform/opentelemetry-operations-java@v0.31.0...v0.32.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/googleapis/sdk-platform-java).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet